Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💻 Teacher1 as super teacher in dev db #5619

Merged
merged 3 commits into from
Jun 19, 2024
Merged

💻 Teacher1 as super teacher in dev db #5619

merged 3 commits into from
Jun 19, 2024

Conversation

Annelein
Copy link
Collaborator

How to test

  • Login as teacher1 and see if they are a super teacher

@jpelay
Copy link
Member

jpelay commented Jun 18, 2024

Can you please add also add the field to the USERS table?

 'second_teacher_in': Optional(ListOf(str)),
 'classes': Optional(SetOf(str)),
 'teacher': Optional(str),
 'pair_with_teacher': Optional(int),
 'teacher_request': Optional(bool),
 'is_super_teacher': Optional(int) # ==> add this

@Annelein Annelein requested a review from jpelay June 19, 2024 09:46
@Annelein Annelein assigned Annelein and jpelay and unassigned Annelein Jun 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5ea8667 into main Jun 19, 2024
12 checks passed
@mergify mergify bot deleted the super-teacher1 branch June 19, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpelay jpelay jpelay approved these changes

Assignees

@jpelay jpelay

Labels
None yet
Projects
Hedy organization board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Annelein @jpelay